Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up audit rpc to UI balance #170

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Conversation

wbobeirne
Copy link
Collaborator

Built on #168, fixes part of #95

Shout out @EthnTuttle for getting started on this

What This Does

  • Adds the api.audit call for federation & module assets and liabilities
  • Hooks up the wallet module's net_assets to the <BalanceCard />
  • Adds new shared types to packages/utils
    • Opaque number types have been added for Btc, Sats, and MSats that makes it so that API types and functions can dictate which specific units they accept, to avoid the ambiguity of number not being clear what denomination it is
  • Adds missing docker-compose.yml depends_on: bitcoin configs for fedimintds

Screenshots

Screenshot 2023-08-31 at 4 31 14 PM

@EthnTuttle
Copy link
Collaborator

Opaque number types have been added for Btc, Sats, and MSats that makes it so that API types and functions can dictate which specific units they accept, to avoid the ambiguity of number not being clear what denomination it is

🧡

@EthnTuttle EthnTuttle merged commit 7167dc6 into guardian-ui-figma-spec Sep 7, 2023
2 checks passed
@EthnTuttle
Copy link
Collaborator

Shoot. I believe this should have been merged into master.

@wbobeirne
Copy link
Collaborator Author

That's OK, I'll open a new PR against master. Usually GitHub is smart enough to re-target the PR to master, not sure why it didn't happen here.

@wbobeirne wbobeirne deleted the audit-balance branch September 7, 2023 18:35
@wbobeirne wbobeirne mentioned this pull request Sep 7, 2023
EthnTuttle added a commit that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants