Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up theme colors & component hex values #164

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Conversation

wbobeirne
Copy link
Collaborator

Untracked cleanup

What This Does

  • Adds red, yellow, and green colors to palette
    • I've aliased these as success, warning and error to match the figma but it's pretty common for themes to both have named colors and aliased colors so that, for instance, you could have a theme that uses a different palette color for a state, e.g. a purple warning or a blue success. I think we should do this with all of the colors like blue and gray at some point with aliases like primary and brand. We already somewhat do this with text and border.
  • Updates all components to use theme.colors.* instead of hard-coded hex values
    • Tweaked Pill component to better match designs overall
      • Renamed color prop to type so that it matches success | warning | error nomenclature
  • Removes unused components
    • guardian-ui's <SideBar />
    • gateway-ui's <Input />
    • I removed them as a part of this PR because I wanted to get rid of all hex values, but had no way to visually confirm changes to these since there is currently no way to get these to render. In general I think we should not leave dead code in the project as we can always restore them via git later.

Screenshots

Screenshot 2023-08-30 at 1 42 43 PM Screenshot 2023-08-30 at 1 40 58 PM Screenshot 2023-08-30 at 1 43 09 PM Screenshot 2023-08-30 at 1 43 20 PM

@wbobeirne wbobeirne changed the title Clean up theme colors & components Clean up theme colors & component hex values Aug 30, 2023
Copy link
Collaborator

@EthnTuttle EthnTuttle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulled and tested.

hex colors are dead, long live the theme!

@EthnTuttle EthnTuttle merged commit dca2a26 into master Aug 31, 2023
3 checks passed
@EthnTuttle EthnTuttle deleted the pill-colors branch August 31, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants