Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add CI linter #149

Merged
merged 3 commits into from
Aug 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: CI

on:
push:
branches: ['master']
pull_request:
types: [opened, synchronize]

jobs:
build:
name: Lint
timeout-minutes: 15
runs-on: ubuntu-latest

steps:
- name: Check out code
uses: actions/checkout@v3
with:
fetch-depth: 2

- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: 18
cache: 'yarn'

- name: Install dependencies
run: yarn

- name: Lint
run: yarn lint
2 changes: 1 addition & 1 deletion apps/guardian-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject",
"lint": "eslint \"src/**/*.ts*\"",
"lint": "eslint \"src/**/*.ts*\" --max-warnings 0",
"clean": "rm -rf build"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion apps/guardian-ui/src/components/ConnectGuardians.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export const ConnectGuardians: React.FC<Props> = ({ next }) => {
rows = [...rows, row];
}
return rows;
}, [numPeers, peers, role, t]);
}, [numPeers, ourCurrentId, peers, t]);

return (
<VStack width='100%' justify='start' align='start' gap={8}>
Expand Down