Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Dependency Updates and Compatibility Issues #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nitinawari
Copy link

This pull request is focused on updating various dependencies within the project, specifically http-body, http-body-util, and Rust to the latest versions. Key changes include:

Dependency Updates:
Replaced http-body with http-body-util.
Updated code to accommodate new Rust version requirements.
Adjusted struct paths and incorporated necessary changes for rustls.

Issues Encountered:
Hyper Library: Significant changes in the Hyper library have caused compatibility issues. Many functionalities related to HTTPS server connections have been altered or removed.
Feature Removal: rustls has removed or relocated some features, affecting imports and implementations.

Current Status:
The code builds successfully but has issues with HTTPS connectivity and Hyper-related functionalities.
Changes have been made to align with the new API structures, but the implementation is incomplete and requires further validation.

Action Needed:
Hyper Functionality: Guidance on understanding the new Hyper API or suggestions for alternatives.
Feature Changes: Assistance with adapting to removed features in rustls or finding equivalent functionality.
Next Steps:

Review the current state of the PR and provide feedback on resolving the issues mentioned.
Suggest any further modifications or alternatives to address compatibility problems.

Branch Information:
Branch: dependency-update-in-progress

Additional Notes:
This PR is a work-in-progress and is not yet ready for merging. It is intended to share the current progress and seek assistance in overcoming the listed issues.

@Kodylow
Copy link
Member

Kodylow commented Sep 9, 2024

@dpc

@tvolk131
Copy link
Member

@nitinawari I'm happy to help debug this! Currently it looks like there are thousands of lines of diffs that don't actually change anything, making it next to impossible for me to see what you're actually changing. Could you clean that up? After that I'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants