chore: upgrade to fedimint 0.3 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
reviewed
Apr 24, 2024
dpc
reviewed
Apr 24, 2024
| /// Migrates the database from version 0 to version 1 by | ||
| /// removing `DummyClientFundsKeyV0` and inserting `DummyClientFundsKeyV1`. | ||
| /// The new key/value pair has an `Amount` as the value. | ||
| pub async fn migrate_to_v1( |
There was a problem hiding this comment.
Thought (no need to do it in this PR): we would probably be better of if the example module was fedimint-module-empty and not dummy module.
dpc
reviewed
Apr 24, 2024
| flakeboxLib = flakebox.lib.${system} { }; | ||
| rustSrc = flakeboxLib.filterSubPaths { | ||
| root = builtins.path { | ||
| name = "fedimint-roastr"; |
There was a problem hiding this comment.
Nit: There's nothing about "roastr" around here. :)
dpc
approved these changes
Apr 24, 2024
dpc
reviewed
Apr 24, 2024
| check_forbidden_dependencies = builtins.readFile ./nix/check-forbidden-deps.sh; | ||
| }; | ||
| lib = pkgs.lib; | ||
| flakeboxLib = flakebox.lib.${system} { }; |
There was a problem hiding this comment.
We should probably keep the previous config passed to flakebox.lib.${system}
|
Seems like the failing stuff was never working, so merging as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading custom-module example to fedimint 0.3.0 while also fixing
nix developfailing on MacOS.On running
cargo buildit compiles successfully.