-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to cloud.gov #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbeaufort
commented
Jan 31, 2022
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
2 times, most recently
from
February 1, 2022 20:10
8d86b79
to
542cd1a
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 2, 2022 14:54
542cd1a
to
5b6db87
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 2, 2022 15:04
5b6db87
to
0f51b0c
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 2, 2022 18:17
91ee60d
to
1d46abc
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 2, 2022 18:38
66b376c
to
6e731bd
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 2, 2022 19:11
7d82f21
to
e76fe97
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 2, 2022 19:37
25d0d92
to
d3df60e
Compare
…/nxg_fec directory is overwritten with a local volume
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
2 times, most recently
from
February 2, 2022 22:11
1954785
to
66ec919
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 2, 2022 22:16
66ec919
to
45f579b
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 2, 2022 22:42
b0e5bc2
to
c303f9c
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 3, 2022 14:33
229807c
to
5f93611
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
3 times, most recently
from
February 3, 2022 17:22
bd42b3d
to
d6f5034
Compare
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 3, 2022 19:38
271262b
to
2e04741
Compare
albertcrowley
suggested changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put inline comments in the PR. The summary is:
- I have a question about the Python version we should be using in general for our CI and dev containers.
- I'm seeing CORS errors in the web console when talking to the cloud.gov API so we need to either fix that up or spin it out to a new issue for later.
albertcrowley
approved these changes
Feb 4, 2022
mjtravers
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of stuff. Good code clean up, too.
lbeaufort
force-pushed
the
feature/40-test-cloud-gov
branch
from
February 7, 2022 14:01
aaa2da1
to
4ee568c
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
debug=False
(and possiblyCORS_ALLOWED_ORIGINS
)DJANGO_SECRET_KEY
from settingsDJANGO_SECRET_KEY
in cloud.gov dev/stage/prod envs. Put in follow-up tickets to rotate.$DATABASE_URL
- see https://docs.cloudfoundry.org/devguide/deploy-apps/environment-variable.html#DATABASE-URLwait_for_db
in deploy command and made sure it works$DATABASE_URL
env var to CircleCIFECFILE_DB_NAME
toFECFILE_TEST_DB_NAME
Steps to test (QA)
Testing URLS
https://fecfile-web-api-dev.app.cloud.gov/api/v1/token/obtain
https://fecfile-web-api-stage.app.cloud.gov/api/v1/token/obtain
https://fecfile-web-api-prod.app.cloud.gov/api/v1/token/obtain
Steps to test/additional developer information (devs)
Deploy with invoke
cf login --sso
invoke deploy --space dev
Deploy with CircleCI
Locally
DATABASE_URL
?(Optional) Create RDS
cf create-service aws-rds small-psql-redundant fecfile-api-rds
(Optional) Restore database from backup
cf connect-to-service -no-client fecfile-web-api fecfile-api-rds
psql --dbname (from ssh window) --host localhost --port (from ssh window) --username (from ssh window) < fec_clean_dev_db_backup-20211227.sql
Testing URLS
https://fecfile-web-api-dev.app.cloud.gov/api/v1/token/obtain
https://fecfile-web-api-stage.app.cloud.gov/api/v1/token/obtain
https://fecfile-web-api-prod.app.cloud.gov/api/v1/token/obtain