Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Japanese full support #728

Merged
merged 67 commits into from
Sep 29, 2024
Merged

Conversation

ratomiru
Copy link
Contributor

Description

  • This is the PR with all FSD pages high-quality translated to japanese language
  • I have passed all pages through chatgpt 4o mini with the reference to main japanese articles about FSD for correct terminology, and then fixed all unnatural texts manually reading it multiple times
  • I left only english text links for references because I guess japanese people mainly can not read other languages except japanese and english. If there is a need, it is still possible to look it up switching to other languages for example. Thanks for understanding!
Demo スクリーンショット 2024-09-29 18 26 49

Question

My japanese company started to use FSD and it is really highly rated! I wonder, maybe it would be good to split "Companies using FSD" section by languages/location to display country local companies? I think other developers/companies will trust FSD more, if it shows them their local country's companies. Of course, there would be a profit for FSD, because there will be a proof that it is used globally. What do you think about it? Thanks!

Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit 68ba05b
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/66f92030ef50ee0008446df8
😎 Deploy Preview https://deploy-preview-728--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is huge, thank you so much!

My japanese company started to use FSD and it is really highly rated! I wonder, maybe it would be good to split "Companies using FSD" section by languages/location to display country local companies? I think other developers/companies will trust FSD more, if it shows them their local country's companies. Of course, there would be a profit for FSD, because there will be a proof that it is used globally. What do you think about it? Thanks!

Yes, this is a good idea. Ideally, we'd want to do it when there would be several companies from each country, but we have to start somewhere, so we might just do it soon. To be honest, it's been a while since we updated that page, since it's not the top priority, but once we get to it, I'll take your suggestion into consideration. Thanks!

@illright illright merged commit ae9c386 into feature-sliced:master Sep 29, 2024
6 checks passed
@ratomiru
Copy link
Contributor Author

@illright

Yes, this is a good idea. Ideally, we'd want to do it when there would be several companies from each country, but we have to start somewhere, so we might just do it soon. To be honest, it's been a while since we updated that page, since it's not the top priority, but once we get to it, I'll take your suggestion into consideration. Thanks!

Got it, thanks!

Also, could you please check algolia settings? It seems that search is currently not working in japanese version

@illright
Copy link
Member

illright commented Oct 4, 2024

Sure, I made an issue so that I don't forget about it, I'll let you know once I get it fixed (I hate dealing with Algolia :D)

#729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants