Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React/Effector example #591

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Conversation

Shiyan7
Copy link
Contributor

@Shiyan7 Shiyan7 commented Jun 8, 2023

Background

Add a great fsd/effector example.

I will be glad to get project review

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit c13e1c0
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/64abe10a67a5820007a77b9d
😎 Deploy Preview https://deploy-preview-591--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не все успел тотально глянуть - но базово чекнул, все шикарно)

Осталось только замечания некоторые поправить и можем вливать 🚀

src/pages/examples/_config.ts Show resolved Hide resolved
@azinit
Copy link
Member

azinit commented Jun 21, 2023

@Shiyan7 подлей мастер еще - а то конфликт )

@azinit
Copy link
Member

azinit commented Jun 22, 2023

@Shiyan7 ping)

@azinit
Copy link
Member

azinit commented Jun 22, 2023

@Shiyan7 пингани как можно будет ревьювить проект еще раз
(но думаю уже вольем после второго раунда ревью)

@azinit
Copy link
Member

azinit commented Jun 27, 2023

@Shiyan7 ping)

src/pages/examples/_config.ts Show resolved Hide resolved
src/pages/examples/_config.ts Outdated Show resolved Hide resolved
@azinit azinit merged commit db3c926 into feature-sliced:master Jul 10, 2023
6 checks passed
@azinit
Copy link
Member

azinit commented Jul 10, 2023

Спасибо за проработанный пример ! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants