chore: Update go targets in Makefile #4861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaniasd
changed the title
Signed-off-by: Dimitris <[email protected]>
xaniasd
force-pushed
the
makefile-go-targets
branch
from
2b5e734 to
4698452
Compare
xaniasd
changed the title
shuchu
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Can we avoid to make a file connection from folder "go" to other file folders? We try to make the Go folder self-contained and limit the dependencies with other directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes or updates some of the go-related targets, specifically addresses the following:
Which issue(s) this PR fixes:
N/A
Misc
target
build-gobuilds a binary in the root directory, it should be moved underdist/(follow-up PR)