feat: Adding vector_search parameter to fields #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
…oing to ignore them so it is backwards compatible Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
franciscojavierarceo
requested review from
tchughesiv,
lokeshrangineni,
dmartinol,
shuchu and
HaoXuAI
dmartinol
reviewed
Dec 18, 2024
|
Yeah it looks like it. I'll make an action to run some checks to verify it from now on. |
|
By the way @dmartinol can you approve? |
dmartinol
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
vector_indexandvector_search_metricto theFeatureprotobuf object (which maps to theFieldclass) that will be used to declare field-level index behavior for online retrieval. I.e., during ingestion we can declare which fields are indexed as vectors for approximate nearest neighbor search.Which issue(s) this PR fixes:
N/A
Misc
N/A