Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactoring release yamls to be more modular and remove redundancies #4826

Merged
merged 12 commits into from
Dec 11, 2024

Conversation

franciscojavierarceo
Copy link
Member

@franciscojavierarceo franciscojavierarceo commented Dec 7, 2024

What this PR does / why we need it:

Refactoring release yamls to be more module and not use redundant code.

Which issue(s) this PR fixes:

Misc

@tchughesiv
Copy link
Contributor

@franciscojavierarceo we probably need a way of ensuring that .github/workflows/publish_python_sdk.yml completes successfully before .github/workflows/publish_images.yml starts. thoughts?

@franciscojavierarceo
Copy link
Member Author

@franciscojavierarceo we probably need a way of ensuring that .github/workflows/publish_python_sdk.yml completes successfully before .github/workflows/publish_images.yml starts. thoughts?

100% I'm just saving my code because I wanted to switch to fixing the images. This PR is draft, so feel free to ignore for now. I'll tag you when ready. 👍

Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo franciscojavierarceo marked this pull request as ready for review December 11, 2024 14:52
@franciscojavierarceo
Copy link
Member Author

@tchughesiv @lokeshrangineni I've refactored the workflows and broken them apart into more reusable components. Can you take a look and see if I missed anything?

Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Francisco Javier Arceo <[email protected]>
Copy link
Contributor

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@franciscojavierarceo franciscojavierarceo merged commit df74ee9 into master Dec 11, 2024
21 checks passed
@franciscojavierarceo franciscojavierarceo changed the title chore: Refactoring release yamls to be more module and not use redund… chore: Refactoring release yamls to be more modular and not use redund… Dec 12, 2024
@franciscojavierarceo franciscojavierarceo changed the title chore: Refactoring release yamls to be more modular and not use redund… chore: Refactoring release yamls to be more modular and remove redundancies Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants