Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Object store persistence in operator #4758

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dmartinol
Copy link
Contributor

What this PR does / why we need it:

This PR adds object store persistence configuration options to the FeatureStore CRD.

  • Support is provided only to the Registry service.
  • Additional S3 configurations are also supported
  • Follows definitions in RFC #42
  • Configuration examples are provided in config/samples
apiVersion: feast.dev/v1alpha1
kind: FeatureStore
metadata:
  name: sample-s3-registry
spec:
  feastProject: my_project
  services:
    onlineStore:
      persistence:
        file:
          path: /data/online_store.db
    offlineStore:
      persistence:
        file:
          type: dask
    registry:
      local:
        persistence:
          file:
            path: s3://bucket/registry.db
            s3_additional_kwargs:
              ServerSideEncryption: AES256
              ACL: bucket-owner-full-control
              CacheControl: max-age=3600

Which issue(s) this PR fixes:

Relates to #4561

Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
@dmartinol dmartinol requested a review from a team as a code owner November 13, 2024 10:14
@dmartinol
Copy link
Contributor Author

@tchughesiv @redhatHameed FYI

Copy link
Contributor

@redhatHameed redhatHameed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -452,6 +452,17 @@ func (in *RegistryFilePersistence) DeepCopyInto(out *RegistryFilePersistence) {
*out = new(PvcConfig)
(*in).DeepCopyInto(*out)
}
if in.S3AddtlKwargs != nil {
in, out := &in.S3AddtlKwargs, &out.S3AddtlKwargs
*out = new(map[string]string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been reassigned in the deep copy using make. Do we need to initialize with empty map?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is generated by make generate, I assume it is corrrect 😉

Copy link
Contributor

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants