Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subgift): ensure msg-param-months is present #76

Merged
merged 2 commits into from
Aug 11, 2020
Merged

fix(subgift): ensure msg-param-months is present #76

merged 2 commits into from
Aug 11, 2020

Conversation

iProdigy
Copy link
Contributor

Default to one month instead of zero so the tag is actually sent (was causing NumberFormatException for us when absent)

Bug found by @Mrbysco

@iProdigy
fix(subgift): ensure msg-param-months is present
f8df50f 
Default to one month instead of zero
@iProdigy
Copy link
Contributor Author

iProdigy commented Jul 19, 2020 •
edited
Loading

Another possibility is to create a tenure or cumulative variable that the user can specify to simulate different values

Edit: done

@trezy trezy self-requested a review August 11, 2020 14:49
trezy
trezy approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@trezy trezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@trezy trezy merged commit 98caf59 into fdgt-apis:main Aug 11, 2020
@trezy trezy linked an issue Aug 11, 2020 that may be closed by this pull request
subgift badge-info and badges have subscriber 0 in methods #62
Open
@trezy trezy removed a link to an issue Aug 11, 2020
subgift badge-info and badges have subscriber 0 in methods #62
Open
@iProdigy iProdigy deleted the patch-1 branch August 11, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trezy trezy trezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iProdigy @trezy