Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Externalize schema registry client #843

Open
wants to merge 6 commits into
base: series/2.x
Choose a base branch
from

Conversation

geirolz
Copy link
Contributor

@geirolz geirolz commented Jan 24, 2022

Recently I had to use fs2-kafka in prod with Protobuf. Since I didn't find any module or library ready to use I started to develop my own implementation ( delegating serialization and deserialization to the confluent library as the Avro module).
Said that I thought that this could be useful for someone else.

I've forked the project starting a new module fs2-kafka-protobuf but I realized that a dedicated module for the schema-registry client could be useful as well. The next step could be creating the protobuf module that uses this new module.

I'm not sure you want to publish this module.
In any case, let me know what do you think about this

@geirolz
Copy link
Contributor Author

geirolz commented Apr 7, 2022

@bplommer any news about this? Thanks 👍

@bplommer
Copy link
Member

bplommer commented May 9, 2022

Seems like a good idea - I'll try and take a look soon.

@bplommer bplommer self-requested a review May 9, 2022 10:58
@bplommer bplommer added this to the v2.6.0 milestone Jul 14, 2022
@geirolz geirolz force-pushed the proposal-extenalize-schema-registry-client branch from 79ccb79 to e253672 Compare October 20, 2022 15:40
…ient

# Conflicts:
#	modules/schema-registry/src/test/scala/fs2/kafka/schemaregistry/client/AuthSpec.scala
#	modules/schema-registry/src/test/scala/fs2/kafka/schemaregistry/client/SchemaRegistryClientSettingsSpec.scala
@aartigao aartigao modified the milestones: v2.6.0, v4.0.0 Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants