add comment property to CandidateWord #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updateClientSideUIImpl in dbusfrontend.cpp also need to be updated, |
wengxt
requested changes
Apr 2, 2024
|
Also, whenever you add new API that was intended to be used by other project immediately, bump the version in CMakeLists.txt in the root if no one bumped the version after the previous release. |
|
Please also add some tests that exercise the new api function in test/testtext.cpp and test/testcandidatelist.cpp |
wengxt
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently comment of a rime candidate is appended into candidate in engine level, so it's hard to distinguish and apply different style.
The PR adds a new property to CandidateWord and preserves the behavior in 3 UI implementations (classicui and kimpanel tested, virtualkeyboard not tested).