Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use zero width space as dummy preedit to avoid text shift #170

Merged
merged 1 commit into from
Jul 6, 2024
Merged

use zero width space as dummy preedit to avoid text shift #170

merged 1 commit into from
Jul 6, 2024

Conversation

eagleoflqj
Copy link
Member

@eagleoflqj eagleoflqj commented Jul 5, 2024 •
edited
Loading

Tested with our old friends:

  • Terminal with empty clipboard: able to esc.
  • Terminal with 双拼 and semicolon: able to use return to commit semicolon.
  • iTerm2 with/without client preedit: no extraneous characters committed.

@eagleoflqj eagleoflqj requested a review from ksqsf July 6, 2024 04:24
ksqsf
ksqsf approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksqsf ksqsf merged commit f87684b into master Jul 6, 2024
4 checks passed
@ksqsf ksqsf deleted the dummy-preedit branch July 6, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksqsf ksqsf ksqsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eagleoflqj @ksqsf