Skip to content

Commit

Permalink
missing docker login on github action before pre-commit
Browse files Browse the repository at this point in the history
  • Loading branch information
fchastanet committed Nov 16, 2023
1 parent 092911d commit cff9a91
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
9 changes: 9 additions & 0 deletions .github/workflows/lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ jobs:
- name: Install pre-commit
run: pip install pre-commit

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Login to DockerHub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- uses: ouzi-dev/commit-status-updater@v2
with:
name: lint
Expand Down
11 changes: 10 additions & 1 deletion .pre-commit-hooks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,16 @@
language: script
entry: bin/frameworkLint
args:
[--bash-framework-config, .framework-config, --expected-warnings-count, '0', --format, plain, --theme, default-force]
[
--bash-framework-config,
.framework-config,
--expected-warnings-count,
'0',
--format,
plain,
--theme,
default-force,
]
pass_filenames: false
types: ['executable', 'file', 'shell', 'text']
always_run: false
Expand Down

0 comments on commit cff9a91

Please sign in to comment.