Skip to content

feat: add support to extended checkbox field in account settings #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Dec 11, 2024

Description

This PR adds support to Extended CheckBox Fields in the Account Settings.

Supporting information

Testing instructions

  1. Create a Tutor environment in the Redwood version.
  2. Install nau-openedx-extensions plugin with the changes in this PR.
  3. Create a mount of edx-platform with the changes in this PR.
  4. Update the account.redirect_to_microfrontend Waffle Flag. Set Everyone to No. This allows access to the legacy interface.
  5. Go to {lms_domain}/account/settings
  6. You should see the new checkbox field in the Additional Information section.
  7. Try to update the field and verify that the value was updated in the model.

Screenshots

image

@BryanttV BryanttV changed the title feat: add support for extended checkbox field in account settings feat: add support to extended checkbox field in account settings Dec 13, 2024
@BryanttV BryanttV marked this pull request as ready for review December 13, 2024 21:31
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @BryanttV. The function works as expected.

My suggestion here is to improve the indentation in lms/static/js/student_account/views/account_settings_fields.js to make it easier to read and clear that the following functions are attached to the ExendedFieldCheckboxFieldView.

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BryanttV. This looks good to me.

Copy link
Member

@igobranco igobranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@igobranco igobranco merged commit 6c85155 into nau/redwood.master Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants