Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "ba" targets in opam build #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented Jul 21, 2022

The "ba" targets have been added to the opam build. This makes it easy to use the current "master" branch in a build, for when you also need the BigArray support.

Added a line to the README.md detailing how the current development branch can be used without manually getting and installing.

@ghost ghost closed this Jul 21, 2022
@csoren
Copy link
Contributor

csoren commented Jul 21, 2022

This is fine with me

@ghost ghost reopened this Jul 21, 2022
@fccm2
Copy link

fccm2 commented Jul 21, 2024

I'm not sure if the command line to compile with bigarrays is the same for all ocaml versions.
This is why I didn't include it by default.

@fccm2
Copy link

fccm2 commented Sep 19, 2024

chatgpt tells me that the command line changes with ocaml 4.06 (to compile with ba's).
Before this version, it seems that no specific parameters was needed to compile with bigarrays, but had to be added with 4.06 and after.
I don't know if this additional parameter would produce an error with versions before 4.06 (or just be ignored).
I also don't know how to add a version switch in the opam file, to change the command line to compile with all past ocaml versions.
chatgpt tells me that it's possible to add a version switch in the build section of the opam file like this:

build: [
  ["compile with ba parameters"] {ocaml:version >= "4.06"}
  ["compile without ba parameters"] {ocaml:version < "4.06"}
]

PS: please also notice, that the functions wrapped with a ba data structure, are also available with a string/bytes data structure, that you can use with the new functions from the String module, to read/write ints from/to a string/bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants