This repository has been archived by the owner on Jan 5, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Add sass-glob #20
Open
andrewleaf
wants to merge
61
commits into
master
Choose a base branch
from
fabricator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add sass-glob #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update third-party docs: webpack
fixes #3
When running two instances of Gulp-Ruby-Sass, the outputs get jumbled together. For Instances, both fabricator.css, and toolkit.css would appear in: config.dest + '/assets/toolkit/styles' Were it not for the rename function in styles:fabricator, the reverse is also true, both fabricator.css and toolkit.css would appear in: config.dest + '/assets/fabricator/styles' The rename functionality added some of its own hiccups, as sometimes it would turn fabricator.scss into f.css first, and then overwrite it by turning toolkit.scss into f.css. This of course caused fabricator to break. Upon further research it was discovered to be a known issue in gulp-ruby-sass that is resolved using containers: https://github.com/sindresorhus/gulp-ruby-sass#container
Update to Gulp-Ruby-Sass Docs to use Containers
Just a couple of minor things to make your project even more awesome than it already is.
I know that is typically a right quote, but it seems a semi colon (which is right next to the right quote) might have been the intended stroke.
Replace — with semicolon
Fix small grammar issues
…e to *its* to make it *it's*.
Correcting typo on on building-a-toolkit/assets
Fixing small typo on data page
Adding missing word to the last section of documentation.
Update Browserify reference in assets.html
# Conflicts: # dist/assets/fabricator/scripts/f.js # dist/assets/toolkit/scripts/toolkit.js # dist/assets/toolkit/styles/toolkit.css # dist/index.html
"Twitter Bootstrap" => "Bootstrap"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sass-glob