Merge pull request #166 from fawkesrobotics/thofmann/buildkite-fedora30

Upgrade buildkite builds to Fedora 30

.buildkite/pipeline.yml

@@ -6,7 +6,7 @@ merged-pr-plugin: &merged-pr-plugin
     mode: checkout
 
 docker-plugin-base: &docker-plugin-base
-  image: fawkesrobotics/fawkes-builder:fedora29-kinetic
+  image: fawkesrobotics/fawkes-builder:fedora30-melodic
   always-pull: true
   debug: true
   environment: ["BUILDKITE", "BUILDKITE_LABEL"]

src/libs/blackboard/blackboard.cpp

@@ -128,7 +128,7 @@ namespace fawkes {
  * @return true if the aliveness could be restored and the BlackBoard is
  * operational again, false otherwise.
  *
- * @fn std::list<Interface *>  BlackBoard::open_multiple_for_reading(const char *type_pattern, const char *id_pattern = "*", const char *owner = NULL)
+ * @fn std::list<Interface *>  BlackBoard::open_multiple_for_reading(const char *type_pattern, const char *id_pattern, const char *owner)
  * Open multiple interfaces for reading.
  * This will create interface instances for currently registered interfaces of
  * the given type that match the given ID pattern. The result can be casted to

src/libs/core/assert_exception.h

@@ -39,6 +39,6 @@
 #define assert(expr)                 \
 	((expr) ? __ASSERT_VOID_CAST(0)    \
 	        : throw fawkes::Exception( \
-	            "Assertion '%s' failed in %s:%u", __STRING(expr), __FILE__, __LINE__))
+	          "Assertion '%s' failed in %s:%u", __STRING(expr), __FILE__, __LINE__))
 
 #endif

src/libs/core/threading/thread_loop_listener.cpp

@@ -31,14 +31,6 @@ namespace fawkes {
  * tasks, which are executed before and after every loop.
  *
  * @author Till Hofmann
- *
- * @fn void ThreadLoopListener::pre_loop(Thread thread*)
- * This is called by the thread every time before loop() is called.
- * @param thread thread whose loop() is will be called.
- *
- * @fn void ThreadLoopListener::post_loop(Thread thread*)
- * This is called by the thread every time after loop() returned.
- * @param thread thread whose loop() just returned.
  */
 
 /** Virtual empty destructor. */
@@ -47,7 +39,7 @@ ThreadLoopListener::~ThreadLoopListener()
 }
 
 /** Empty stub for the pre loop function of the loop listener.
- * This function is called right before the loop of the thread with the aspect.
+ * This function is called by the thread every time before loop() is called.
  * Provide a stub such that not every derived class must implement the function.
  * @param thread thread this loop listener belongs to
  */
@@ -57,7 +49,7 @@ ThreadLoopListener::pre_loop(Thread *thread)
 }
 
 /** Empty stub for the post loop function of the loop listener.
- * This function is called right after the loop of the thread with the aspect.
+ * This function is called by the thread every time after loop() returned.
  * Provide a stub such that not every derived class must implement the function.
  * @param thread thread this loop listener belongs to
  */

src/libs/fvclassifiers/border_shrinker.h

@@ -33,14 +33,6 @@ class ROI;
 class BorderShrinker : public Shrinker
 {
 public:
-	/** CloseShrinker shrinks ROIs
-   * It will make sure that any ROI that passes it will NOT be in the border regions
-   * denoted by the pixels
-   * @param border_left left pixel margin
-   * @param border_right right pixel margin
-   * @param border_top top pixel margin
-   * @param border_bottom botto pixel margin
-   */
 	BorderShrinker(unsigned int border_left   = 0,
 	               unsigned int border_right  = 0,
 	               unsigned int border_top    = 0,

src/libs/fvmodels/shape/ht_lines.cpp

@@ -41,13 +41,22 @@ namespace firevision {
  */
 
 /** Constructor.
- * @param nr_candidates number of candidates
- * @param angle_from slope of lines from
- * @param angle_range angle range
- * @param r_scale r scale
- * @param min_votes_ratio min votes ratio
- * @param min_votes minimum number of votes for a candidate to consider
- */
+  * Creates a new HtLinesModel instance
+  * @param nr_candidates the nr of candidates that is considered per pixel (the hole angle
+  *                      range is devided in this many parts/lines
+  * @param angle_from The angle to start the candidates from, given in rad, 0 is straight up
+  * @param angle_range the angle range the candidates are taken from starting at angle_from,
+  *                    given in rad, can be used for example to only search for horizontal lines
+  * @param r_scale This can be done to reduce the size of the hough space and to map more lines
+  *                to one line
+  * @param min_votes_ratio The minimum ratio num_votes_per_line/total_num_votes that we have to
+  *                        have before a point in the hough space is considered to be a line,
+  *                        this may actually be higher if you use min_votes and set it to a higher
+  *                        number (set min_votes to 0 to only use min_votes_ration)
+  * @param min_votes the minimum number of votes a point in the hough space has to have before it
+  *                  is considered to be a line. The number may actually be higher if min_votes_ratio
+  *                  is set too high (set min_votes_ration to 0 to use only min_votes)
+  */
 HtLinesModel::HtLinesModel(unsigned int nr_candidates,
                            float        angle_from,
                            float        angle_range,

src/libs/fvmodels/shape/ht_lines.h

@@ -44,22 +44,6 @@ class HtLinesModel : public ShapeModel
 	RhtAccumulator         accumulator;
 
 public:
-	/** Creates a new HtLinesModel instance
-   * @param nr_candidates the nr of candidates that is considered per pixel (the hole angle
-   *                      range is devided in this many parts/lines
-   * @param angle_from The angle to start the candidates from, given in rad, 0 is straight up
-   * @param angle_range the angle range the candidates are taken from starting at angle_from,
-   *                    given in rad, can be used for example to only search for horizontal lines
-   * @param r_scale This can be done to reduce the size of the hough space and to map more lines
-   *                to one line
-   * @param min_votes_ratio The minimum ratio num_votes_per_line/total_num_votes that we have to
-   *                        have before a point in the hough space is considered to be a line,
-   *                        this may actually be higher if you use min_votes and set it to a higher
-   *                        number (set min_votes to 0 to only use min_votes_ration)
-   * @param min_votes the minimum number of votes a point in the hough space has to have before it
-   *                  is considered to be a line. The number may actually be higher if min_votes_ratio
-   *                  is set too high (set min_votes_ration to 0 to use only min_votes)
-   */
 	HtLinesModel(unsigned int nr_candidates   = 40,
 	             float        angle_from      = 0,
 	             float        angle_range     = 2 * M_PI,

src/libs/syncpoint/tests/test_syncpoint.cpp

@@ -75,14 +75,12 @@ class SyncPointTest : public ::testing::Test
 		delete logger_;
 	}
 
-	/**@{*/
-	/**
-     * Syncpoints for testing purposes
-     */
+	/** A syncpoint for testing */
 	RefPtr<SyncPoint> sp1;
+	/** A syncpoint for testing */
 	RefPtr<SyncPoint> sp2;
+	/** A syncpoint for testing */
 	RefPtr<SyncPoint> sp3;
-	/**@}*/
 
 	/** Logger for testing */
 	MultiLogger *logger_;

src/libs/webview/request.h

@@ -268,11 +268,6 @@ class WebRequest
 		cookies_[key] = value;
 	}
 
-	/** Set a POST value.
-   * @param key key of the cookie
-   * @param data incoming data
-   * @param size size in bytes of @p data
-   */
 	void set_post_value(const char *key, const char *data, size_t size);
 
 	/** Set a GET value.

src/plugins/asp/aspect/clingo_access.cpp

@@ -272,28 +272,23 @@ ClingoAccess::alloc_control()
 		argumentsChar.push_back(argumentsString.back().c_str());
 	}
 
-	control_ = new Clingo::Control(argumentsChar,
-	                               [this](const Clingo::WarningCode code, char const *msg) {
-		                               fawkes::Logger::LogLevel level = fawkes::Logger::LL_NONE;
-		                               switch (code) {
-		                               case Clingo::WarningCode::AtomUndefined:
-		                               case Clingo::WarningCode::OperationUndefined:
-		                               case Clingo::WarningCode::RuntimeError:
-			                               level = fawkes::Logger::LL_ERROR;
-			                               break;
-		                               case Clingo::WarningCode::Other:
-		                               case Clingo::WarningCode::VariableUnbounded:
-			                               level = fawkes::Logger::LL_WARN;
-			                               break;
-		                               case Clingo::WarningCode::FileIncluded:
-		                               case Clingo::WarningCode::GlobalVariable:
-			                               level = fawkes::Logger::LL_INFO;
-			                               break;
-		                               }
-		                               logger_->log(level, log_comp_.c_str(), msg);
-		                               return;
-	                               },
-	                               100);
+	control_ = new Clingo::Control(
+	  argumentsChar,
+	  [this](const Clingo::WarningCode code, char const *msg) {
+		  fawkes::Logger::LogLevel level = fawkes::Logger::LL_NONE;
+		  switch (code) {
+		  case Clingo::WarningCode::AtomUndefined:
+		  case Clingo::WarningCode::OperationUndefined:
+		  case Clingo::WarningCode::RuntimeError: level = fawkes::Logger::LL_ERROR; break;
+		  case Clingo::WarningCode::Other:
+		  case Clingo::WarningCode::VariableUnbounded: level = fawkes::Logger::LL_WARN; break;
+		  case Clingo::WarningCode::FileIncluded:
+		  case Clingo::WarningCode::GlobalVariable: level = fawkes::Logger::LL_INFO; break;
+		  }
+		  logger_->log(level, log_comp_.c_str(), msg);
+		  return;
+	  },
+	  100);
 	return;
 }
 
@@ -617,18 +612,19 @@ ClingoAccess::assign_external(const Clingo::Symbol &atom, const Clingo::TruthVal
 	}
 
 	if (debug_level_ >= ASP_DBG_EXTERNALS) {
-		logger_->log_info(log_comp_.c_str(),
-		                  "Assigning %s to %s.",
-		                  [value](void) {
-			                  const char *ret = "Unknown Value";
-			                  switch (value) {
-			                  case Clingo::TruthValue::Free: ret = "Free"; break;
-			                  case Clingo::TruthValue::True: ret = "True"; break;
-			                  case Clingo::TruthValue::False: ret = "False"; break;
-			                  }
-			                  return ret;
-		                  }(),
-		                  atom.to_string().c_str());
+		logger_->log_info(
+		  log_comp_.c_str(),
+		  "Assigning %s to %s.",
+		  [value](void) {
+			  const char *ret = "Unknown Value";
+			  switch (value) {
+			  case Clingo::TruthValue::Free: ret = "Free"; break;
+			  case Clingo::TruthValue::True: ret = "True"; break;
+			  case Clingo::TruthValue::False: ret = "False"; break;
+			  }
+			  return ret;
+		  }(),
+		  atom.to_string().c_str());
 	}
 	control_->assign_external(atom, value);
 	return true;

src/plugins/perception/pcl-db/pcl_db_retrieve_pipeline.h

@@ -58,7 +58,6 @@ class PointCloudDBRetrievePipeline : public PointCloudDBPipeline<PointType>
    * @param mongodb_client MongoDB client
    * @param config configuration
    * @param logger Logger
-   * @param output output point cloud
    * @param transformer TF transformer for point cloud transformations between
    * coordinate reference frames
    * @param original input point cloud