Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus registry #613

Merged

Conversation

krzysieksulejczak
Copy link
Contributor

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

The setup_prometheus_sensors function accepts registry parameter with default set to default prometheus registry. The web view to render metrics explicitly uses prometheus default registry. If anyone uses non-default registry in call to setup_prometheus_sensors the metrics will not be available through web view.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.72%. Comparing base (5330c45) to head (d03c501).

Files Patch % Lines
faust/sensors/prometheus.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         102      102           
  Lines       11122    11122           
  Branches     1545     1545           
=======================================
  Hits        10424    10424           
  Misses        607      607           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wbarnha wbarnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM!

@wbarnha wbarnha merged commit 34ae8ec into faust-streaming:master Mar 4, 2024
20 of 23 checks passed
@krzysieksulejczak krzysieksulejczak deleted the fix_prometheus_registry branch March 4, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants