-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use loop.create_task()
for agent tasks
#598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit goes to @samtx for finding this solution for faust-streaming#175 (comment)
Co-authored-by: Sam Friedman <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 102 102
Lines 11158 11158
Branches 1536 1536
=======================================
Hits 10459 10459
Misses 612 612
Partials 87 87 ☔ View full report in Codecov by Sentry. |
patkivikram
approved these changes
Jan 3, 2024
wbarnha
approved these changes
Jan 3, 2024
Thanks for the PR! Here's to hoping for more stability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where asyncio tasks were created directly with the
asyncio.Task()
class instead of usingloop.create_task()
orasyncio.create_task()
. The Python documentation specifically says to not create anasyncio.Task
directly. Creating the task directly could lead to issues when using alternate event loops like uvloop. The Python abstract event loop has a dedicatedloop.set_task_factory
method for overriding the function to create theasyncio.Task
. An application using a custom asyncio task factory could experience weird, unknown behavior, especially if the agents raise an exception or hang due to blocking code.