Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate dynamic attributes for setuptools v69.0.0 and move some metadata definitions into pyproject.toml #574

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

wbarnha
Copy link
Member

@wbarnha wbarnha commented Nov 27, 2023

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Will eliminate need for pinning setuptools<69.0.0 for non-wheel builds.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58b18a1) 93.72% compared to head (1e5d264) 93.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         102      102           
  Lines       11166    11166           
  Branches     1537     1537           
=======================================
  Hits        10465    10465           
  Misses        613      613           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyproject.toml Outdated Show resolved Hide resolved
@wbarnha wbarnha self-assigned this Nov 27, 2023
@wbarnha wbarnha marked this pull request as ready for review November 27, 2023 15:09
@wbarnha wbarnha requested a review from patkivikram November 27, 2023 15:12
@wbarnha wbarnha changed the title Consolidate dynamic attributes for setuptools v69.0.0 Consolidate dynamic attributes for setuptools v69.0.0 and move some metadata definitions into pyproject.toml Nov 27, 2023
@wbarnha wbarnha merged commit ddef30e into master Nov 27, 2023
15 of 18 checks passed
@wbarnha wbarnha deleted the setuptools-fixup branch November 27, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant