update syntax highlighting regex str #93
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax highlighting for the following functions has yet to be added:
This pull request updates it to be in-line with the current syntax and is ordered as per https://docs.fauna.com/fauna/current/api/fql/cheat_sheet (which looks like the order the regex is following).
It also drops all deprecated syntax from being highlighted. The following has been removed:
If that's not desired behavior, it can be modified, but as there's no linting rule to warn against deprecated syntax I feel like this can be one such alternative.
For example, I had assumed
Identity()
was valid syntax (it still is) and forgot it was deprecated because so many people are still using it. Honestly, the only flag that warned me of missing syntax highlighting was the factReverse()
wasn't highlighted. Then I usedCurrentIdentity()
...p.s. I use
Reverse()
so much. Love it. I hope I'm not abusing it and there isn't a performance issue that I'm unaware of.