Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle 410 response #183

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: Handle 410 response #183

merged 2 commits into from
Nov 12, 2024

Conversation

cynicaljoy
Copy link
Contributor

BT-5306

Description

Handle 410 responses from Fauna

Motivation and context

During the Event Feeds testing we found that the error returned from 410s was insufficient.

How was the change tested?

I tweaked one of the unit tests locally to include one of my production keys that doesn't have the Event Feed feature enabled:

    event_feed_test.go:45: failed to load page: Event Feeds are disabled for your current plan or account. Please upgrade your plan or contact support at https://support.fauna.com

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@pnwpedro pnwpedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is just a test label, I think we're okay.

@cynicaljoy cynicaljoy merged commit 0de1e35 into main Nov 12, 2024
5 checks passed
@cynicaljoy cynicaljoy deleted the handle-410 branch November 12, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants