Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Event Feeds #174

Merged
merged 24 commits into from
Nov 1, 2024
Merged

feat: Event Feeds #174

merged 24 commits into from
Nov 1, 2024

Conversation

cynicaljoy
Copy link
Contributor

BT-5172

Stacked PR for: #173

Description

Add support for Event Feeds

Motivation and context

Feature parity

How was the change tested?

Unit Tests included

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cynicaljoy

This comment was marked as outdated.

@cynicaljoy cynicaljoy changed the base branch from main to refactor-stream October 23, 2024 14:20
@cynicaljoy cynicaljoy force-pushed the event-feed branch 2 times, most recently from cc6058a to 9bca1fe Compare October 23, 2024 14:47
@cynicaljoy cynicaljoy force-pushed the refactor-stream branch 2 times, most recently from c5ff934 to 119944b Compare October 28, 2024 18:53
Base automatically changed from refactor-stream to main October 28, 2024 18:55
@cynicaljoy cynicaljoy marked this pull request as ready for review October 28, 2024 19:28
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
request.go Outdated Show resolved Hide resolved
event_feed.go Outdated Show resolved Hide resolved
event_feed.go Outdated Show resolved Hide resolved
event_feed_test.go Outdated Show resolved Hide resolved
event_feed_test.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
cynicaljoy and others added 3 commits October 29, 2024 10:51
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: Lucas Pedroza <[email protected]>
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
event_feed.go Outdated Show resolved Hide resolved
event_feed.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
event_feed.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@pnwpedro pnwpedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is looking very clean :)

A couple validation checks and I'll give it a ship!

client.go Show resolved Hide resolved
event_feed.go Show resolved Hide resolved
event_feed.go Outdated Show resolved Hide resolved
github-actions[bot]

This comment was marked as resolved.

Copy link
Collaborator

@pnwpedro pnwpedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 lgtm!

@cynicaljoy cynicaljoy merged commit 5824a2c into main Nov 1, 2024
5 checks passed
@cynicaljoy cynicaljoy deleted the event-feed branch November 1, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants