-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Event Feeds #174
Merged
Merged
feat: Event Feeds #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
cynicaljoy
force-pushed
the
event-feed
branch
2 times, most recently
from
October 23, 2024 14:47
cc6058a
to
9bca1fe
Compare
cynicaljoy
force-pushed
the
refactor-stream
branch
from
October 23, 2024 21:47
e4eea78
to
a8f11e6
Compare
cynicaljoy
force-pushed
the
event-feed
branch
from
October 23, 2024 21:52
9bca1fe
to
668c44f
Compare
cynicaljoy
force-pushed
the
refactor-stream
branch
2 times, most recently
from
October 28, 2024 18:53
c5ff934
to
119944b
Compare
cynicaljoy
force-pushed
the
event-feed
branch
from
October 28, 2024 18:59
400d0f4
to
619df39
Compare
pnwpedro
requested changes
Oct 29, 2024
jrodewig
reviewed
Oct 29, 2024
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: Lucas Pedroza <[email protected]>
pnwpedro
reviewed
Oct 29, 2024
pnwpedro
reviewed
Oct 29, 2024
erickpintor
reviewed
Oct 29, 2024
pnwpedro
reviewed
Oct 31, 2024
cynicaljoy
force-pushed
the
event-feed
branch
from
November 1, 2024 12:50
38f5087
to
648d1bf
Compare
cynicaljoy
force-pushed
the
event-feed
branch
from
November 1, 2024 12:59
648d1bf
to
9d2f788
Compare
pnwpedro
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is looking very clean :)
A couple validation checks and I'll give it a ship!
pnwpedro
requested changes
Nov 1, 2024
pnwpedro
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BT-5172
Stacked PR for: #173
Description
Add support for Event Feeds
Motivation and context
Feature parity
How was the change tested?
Unit Tests included
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.