Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update report aligning to the mockup #717

Merged
merged 8 commits into from
Nov 25, 2020

Conversation

noursaidi
Copy link
Collaborator

@noursaidi noursaidi commented Nov 21, 2020

Issue #708 - Updates the category table to report to match the agreed report mockup. Example of new table below. Also adds a new warning when a test is gone to alert to possible misconfiguration

Some items which cropped up and may need addressing in the future is the 'required':'pass'


Some tests report as GONE. Please check for possible misconfiguration

Category Total Tests Result Required Pass Required Pass for PoE Devices Required Pass for BACnet Devices Recommended Pass Information Other
Connection 9 FAIL 1/4/4 0/0/0 0/0/0 0/0/0 0/0/0 0/0/0
Security 8 FAIL 1/0/4 0/0/0 0/0/0 1/1/0 0/0/1 0/0/0
Network Time 2 PASS 2/0/0 0/0/0 0/0/0 0/0/0 0/0/0 0/0/0
TLS 0 N/A 0/0/0 0/0/0 0/0/0 0/0/0 0/0/0 0/0/0
Protocol 2 FAIL 0/0/0 0/0/0 0/1/0 0/0/0 0/0/1 0/0/0
PoE 3 FAIL 0/0/0 0/1/1 0/0/0 0/0/0 0/1/0 0/0/0
BOS 1 SKIP 0/0/0 0/0/0 0/0/0 0/0/1 0/0/0 0/0/0
Other 2 GONE 0/0/0 0/0/0 0/0/0 0/0/0 0/0/0 0/2/0
Communication 2 GONE 0/1/0 0/0/0 0/0/0 0/0/0 0/1/0 0/0/0

Syntax: Pass / Fail / Skip

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #717 (f3e387b) into master (43c398d) will decrease coverage by 0.07%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   82.15%   82.08%   -0.08%     
==========================================
  Files          29       29              
  Lines        4147     4181      +34     
==========================================
+ Hits         3407     3432      +25     
- Misses        740      749       +9     
Flag Coverage Δ
aux 74.62% <97.82%> (-0.01%) ⬇️
base 76.94% <56.52%> (-0.88%) ⬇️
dhcp 73.30% <56.52%> (-0.22%) ⬇️
many 73.25% <56.52%> (-0.77%) ⬇️
topo 72.15% <56.52%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/report.py 99.67% <97.82%> (-0.33%) ⬇️
daq/test_modules/external_module.py 92.06% <0.00%> (-4.77%) ⬇️
daq/base_gateway.py 89.86% <0.00%> (-2.03%) ⬇️
daq/runner.py 89.32% <0.00%> (-0.15%) ⬇️
daq/host.py 91.45% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c398d...d139afd. Read the comment docs.

@noursaidi noursaidi marked this pull request as ready for review November 21, 2020 22:13
@noursaidi noursaidi changed the title Update report aligning to mockup (708) Update report aligning to the mockup Nov 22, 2020
Copy link
Collaborator

@pisuke pisuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor comment about the info output, but looks good to be merged.

daq/report.py Show resolved Hide resolved
@pisuke pisuke merged commit c3a1227 into faucetsdn:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants