Drop macos x86 from Actions matrix #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the latest macos using x86 architecture from the GitHub Actions matrix we use for running tests. Since we dropped support for Python 3.8, we don't need to test Harmonica with oldest versions in macos runners with x86 cpus.
santisoler
force-pushed
the
macos-py3.9-ci
branch
from
3f182a6
to
8988c55
Compare
|
@leouieda, if we want to stop using x86 macos on CI, we should bump the minimum scikit-learn version, since PyPI doesn't provide binaries for sklearn 1.0.0 for arm64 macos. I think we can keep running test on macos x86 until we drop 3.9. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the latest macos using x86 architecture from the GitHub Actions matrix we use for running tests. Since we dropped support for Python 3.8, we don't need to test Harmonica with oldest versions in macos runners with x86 cpus.
Relevant issues/PRs:
Related to #497