Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reordered operations in python notebook #28

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

lauravchrobak
Copy link
Contributor

Switched order of imports to avoid ipyleaflet error with FathomNet install and added explanation on running outside of colab.

…stall and added explination on running outside of colab.
@kevinsbarnard
Copy link
Member

Testing with https://colab.research.google.com/github/fathomnet/fathomnet-py/blob/colab-reorder/tutorial.ipynb.

This issue with the dependency resolution seems to still be present:
image

That said, testing the rest of the notebook (in particular the cell using ipyleaflet), all seems to work. I believe this warning is harmless at the moment. I'll go ahead and merge this into develop.

@kevinsbarnard kevinsbarnard changed the base branch from main to develop July 2, 2024 18:21
@kevinsbarnard kevinsbarnard merged commit 48afc49 into develop Jul 2, 2024
6 checks passed
@kevinsbarnard kevinsbarnard deleted the colab-reorder branch July 2, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants