Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import xls files #889

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Import xls files #889

wants to merge 24 commits into from

Conversation

luilver
Copy link
Contributor

@luilver luilver commented Oct 1, 2020 •
edited
Loading

Remove deprecation warnings: Fix #888

Add Import xls and xlsx files feature.

luilver and others added 21 commits October 1, 2020 16:53
@luilver
Remove deprecation warnings
1d6e840 
Fix fatfreecrm#888
@luilver
Add imported files
1e506a6
@luilver
Fix magic string on imported file factory
9804bbb
@luilver
Change file to be imported to MS-Excel format
06f29f0 
Spreadsheet gem only supports MS-Excel as per described:
https://github.com/zdavatz/spreadsheet#description
@luilver
Merge pull request #2 from luilver/xls_files
99e209b 
Xls files
@ruby232
Add docker-compose.override.yml to .gitignore
11d140c
@ruby232
Import campaign firts version
02d3d2b
@ruby232
Remove extension in shema
a047343
@ruby232
Importe new version init
96c3661
@ruby232
Import new way
eda70db
@ruby232
Import OK
1c2ef55
@ruby232
Import 'campaign' OK
02bcb62
@ruby232
Import 'lead' OK
08a567e
@ruby232
Restore model lead an campaning
889db48
@ruby232
Remove unused files
c9c2117
@ruby232
Restore permission in vendor
0e4e738
@ruby232
Improving select
974cb3a
@ruby232
Importa address
ba5edf6
@ruby232
Remove plpgsql
90d1cb8
@luilver
Merge pull request fatfreecrm#3 from ruby232/import_from_file
aca6861 
Import from EXCEL file
@luilver
Add importer spec file
a803eb8 
Rename importer model into files folder
@CloCkWeRX
Copy link
Member

I'm happy to merge 1d6e840 if its fixing deprecation warnings (which ones?); but you might want to cherry pick to a specific branch rather than master.

@luilver
Copy link
Contributor Author

luilver commented Feb 20, 2021 •
edited
Loading

I'm happy to merge 1d6e840 if its fixing deprecation warnings (which ones?); but you might want to cherry pick to a specific branch rather than master.

This is the deprecation warning: #888

Which branch should I cherry pick instead of master ?

@luilver luilver changed the title Remove deprecation warnings Import xls files Feb 20, 2021
@luilver luilver requested a review from CloCkWeRX February 24, 2021 12:15
@luilver luilver marked this pull request as draft February 24, 2021 12:15
@CloCkWeRX
Copy link
Member

CloCkWeRX commented May 7, 2021 •
edited
Loading

@luilver Try something like

git remote add upstream [email protected]:fatfreecrm/fat_free_crm.git
git fetch upstream
git checkout upstream/master
git checkout -b fix-deprecation
git cherry-pick 1d6e840
git push origin fix-deprecation

and that should give you just that change on an isolated branch as a PR.

@hubyhuby
Copy link

hubyhuby commented Aug 6, 2024

Any news on this interesting feature ?
I need it for one of my projects.
Thks for this wonderfull project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloCkWeRX CloCkWeRX Awaiting requested review from CloCkWeRX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warnings should be removed
4 participants
@luilver @CloCkWeRX @hubyhuby @ruby232