config: add VhostEnableH2C flag to support HTTP/2 cleartext upgrade #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The better approach is to submit an issue first, engage in a discussion, reach a consensus, and then submit the code. |
|
I'd prefer not to introduce new optional parameters. Maybe we can support this functionality transparently so users don't need to make any changes. |
11 tasks
|
PRs go stale after 14d of inactivity. Stale PRs rot after an additional 3d of inactivity and eventually close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
Support
h2cin virtual host.Our use case is:
In front of the vhost, we deploy a caddy to reverse the traffic to frps. And use caddy do tls termination, we got a bug, the client always get an error
internal: protocol error: no Grpc-Status trailer: unexpected EOFwhen requesting a GRPC streaming API(works well on unary API).After some investigation and debug, I found we can fix it by support h2c on the vhost layer.
refrence:
close #4563