Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Minitest to version 5.22.x (Drop Ruby 2.4 and 2.5 from CI) #115

Merged
merged 9 commits into from
Mar 2, 2024

Conversation

etagwerker
Copy link
Member

@etagwerker etagwerker commented Dec 7, 2023

  • Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading.

Description:

It updates the minitest dependency to the latest stable version (5.22.x)

This means that we need to stop testing the library with Ruby 2.4 and 2.5, as minitest has dropped support for these versions.

I will abide by the code of conduct.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (047e28d) to head (296ec99).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          17       17           
  Lines         307      307           
=======================================
  Hits          304      304           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Minitest no longer supports Ruby 2.4 and 2.5, so then this is a reasonable change
Add a title for #115
@etagwerker etagwerker requested a review from JuanVqz March 2, 2024 17:13
@etagwerker etagwerker changed the title Upgrade minitest Upgrade Minitest to version 5.22.x (Drop Ruby 2.4 and 2.5 from test suite) Mar 2, 2024
@etagwerker etagwerker changed the title Upgrade Minitest to version 5.22.x (Drop Ruby 2.4 and 2.5 from test suite) Upgrade Minitest to version 5.22.x (Drop Ruby 2.4 and 2.5 from CI) Mar 2, 2024
Make the minitest dependency definition more open
@etagwerker etagwerker merged commit 6917bc8 into main Mar 2, 2024
14 checks passed
@etagwerker etagwerker deleted the upgrade-minitest branch March 2, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant