Skip to content

Update skunk workflows #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 14, 2023
Merged

Update skunk workflows #104

merged 7 commits into from
Feb 14, 2023

Conversation

JuanVqz
Copy link
Member

@JuanVqz JuanVqz commented Feb 8, 2023

  • Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading.

Description:

When working on #103 I saw the CI was broken, so, this is fixing it.

I will abide by the code of conduct.

@JuanVqz JuanVqz force-pushed the update-skunk-workflow branch from 46423c4 to ce3fd6a Compare February 8, 2023 04:25
@JuanVqz JuanVqz marked this pull request as ready for review February 8, 2023 04:26
@JuanVqz JuanVqz requested a review from a team as a code owner February 8, 2023 04:26
@JuanVqz JuanVqz requested review from ashwinisukale and KostiantynPopovych and removed request for a team February 8, 2023 04:26
@JuanVqz JuanVqz self-assigned this Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #104 (d6f01e4) into main (6a601a5) will not change coverage.
The diff coverage is n/a.

❗ Current head d6f01e4 differs from pull request most recent head 50c8215. Consider uploading reports for the commit 50c8215 to get more accurate results

@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          25       25           
  Lines         465      465           
=======================================
  Hits          457      457           
  Misses          8        8           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JuanVqz JuanVqz changed the title Update skunk workflow Update skunk workflows Feb 8, 2023
@JuanVqz
Copy link
Member Author

JuanVqz commented Feb 8, 2023

Just for the record, this compatibility page helped me to know what bundler's version corresponds to which Ruby.

@JuanVqz JuanVqz requested a review from etagwerker February 8, 2023 05:16
@JuanVqz JuanVqz force-pushed the update-skunk-workflow branch from d6f01e4 to 85d9814 Compare February 10, 2023 01:22
@JuanVqz JuanVqz force-pushed the update-skunk-workflow branch from 85d9814 to 50c8215 Compare February 10, 2023 01:25
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanVqz Looks good to me, thank you! 💯

@etagwerker etagwerker merged commit 4754640 into main Feb 14, 2023
@etagwerker etagwerker deleted the update-skunk-workflow branch February 14, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants