-
Notifications
You must be signed in to change notification settings - Fork 11
Add TS|TSX|JSX files count in javascripts
count
#42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -14,7 +14,7 @@ | |||
RailsStats::CodeStatistics.new(root_directory).to_s | |||
end | |||
|
|||
assert_equal table, out | |||
assert_equal table.delete(" \n"), out.delete(" \n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes CI runs, removing whitespaces from lines compared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hmdros Looks good, could you please address the conflicts? Thanks!
just a comment (not sure if it's out of the scope of the change), but you might want to consider including |
Will add it! Thanks for flagging it |
javascripts
countjavascripts
count
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 83.20% 82.85% -0.35%
==========================================
Files 19 19
Lines 750 735 -15
==========================================
- Hits 624 609 -15
Misses 126 126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes: #26
CHANGELOG.md
that links to this PR under the "main (unreleased)" heading.Description:
This PR adds support to include
.ts
,.tsx
and.jsx
files to theJavascripts
count of the output of rake stats command run.I will abide by the code of conduct.