Skip to content

Add TS|TSX|JSX files count in javascripts count #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hmdros
Copy link
Contributor

@hmdros hmdros commented May 29, 2025

Closes: #26

  • Add an entry to CHANGELOG.md that links to this PR under the "main (unreleased)" heading.

Description:

This PR adds support to include .ts, .tsx and .jsx files to the Javascripts count of the output of rake stats command run.

I will abide by the code of conduct.

@@ -14,7 +14,7 @@
RailsStats::CodeStatistics.new(root_directory).to_s
end

assert_equal table, out
assert_equal table.delete(" \n"), out.delete(" \n")
Copy link
Contributor Author

@hmdros hmdros May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes CI runs, removing whitespaces from lines compared

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmdros Looks good, could you please address the conflicts? Thanks!

@hmdros hmdros force-pushed the ts-files-support branch from 7137371 to 1b08da2 Compare May 30, 2025 12:05
@arielj
Copy link

arielj commented May 30, 2025

just a comment (not sure if it's out of the scope of the change), but you might want to consider including jsx and tsx files too, cause it's really really common to have mostly those when there's React involved

@hmdros hmdros force-pushed the ts-files-support branch from 1b08da2 to 0e87202 Compare May 30, 2025 12:09
@hmdros
Copy link
Contributor Author

hmdros commented May 30, 2025

just a comment (not sure if it's out of the scope of the change), but you might want to consider including jsx and tsx files too, cause it's really really common to have mostly those when there's React involved

Will add it! Thanks for flagging it

@hmdros hmdros changed the title Add TS files count in javascripts count Add TS|TSX|JSX files count in javascripts count May 30, 2025
@hmdros hmdros force-pushed the ts-files-support branch from d574981 to 6309657 Compare May 30, 2025 12:27
@hmdros hmdros force-pushed the ts-files-support branch from 6309657 to 0c087a8 Compare May 30, 2025 12:37
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (3a87be4) to head (8cfe4a1).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   83.20%   82.85%   -0.35%     
==========================================
  Files          19       19              
  Lines         750      735      -15     
==========================================
- Hits          624      609      -15     
  Misses        126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmdros hmdros requested a review from etagwerker May 30, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Typescript files
3 participants