Simplify running outside of an app #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Apr 3, 2025
| @@ -3,8 +3,6 @@ | |||
| module RailsStats | |||
| class ConsoleFormatter < StatsFormatter | |||
| def to_s | |||
| Bundler::Stats::CLI.start | |||
There was a problem hiding this comment.
@etagwerker I saw that you added this in #21
It was causing me trouble because Bundler was trying to interpret the first command line argument as a Bundler command.
The gem reporting seems to still work without it, so perhaps it was only needed for an older version of Bundler?
There was a problem hiding this comment.
Actually, I think it's not correctly counting the gems, I'll need to dig into this a bit more.
| @@ -14,7 +14,7 @@ Gem::Specification.new do |spec| | |||
| spec.license = "MIT" | |||
|
|
|||
| spec.files = `git ls-files -z`.split("\x0") | |||
| spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } | |||
| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | |||
There was a problem hiding this comment.
Changed to match the newer Bundler convention.
andyw8
force-pushed
the
andyw8/simplify-running-outside-of-app
branch
from
9395229 to
2f55046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdthat links to this PR under the "main (unreleased)" heading.This change allows
rails_statsto be run from anywhere, without needing aRakefile.