Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROAD-540 Escape HTML in stories' description and extra info fields #300

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

arielj
Copy link
Contributor

@arielj arielj commented Sep 4, 2023

Jira Ticket

https://ombulabs.atlassian.net/browse/ROAD-540

Motivation / Context

Fixes #252

The solution was really simple, Redcarpet includes an option for the HTML parser to escape HTML and only parse markdown

QA / Testing Instructions

Create/edit a story and write HTML code in the description or the extra info fields. The preview will display the code instead of rendering html tags.

Screenshots:

Form:
image

Show:
image

Action Plan output:
image


I will abide by the code of conduct.

@aisayo aisayo temporarily deployed to points-road-540-escape--pzysil September 6, 2023 17:40 Inactive
@ABizzinotto ABizzinotto merged commit ec32eed into main Sep 6, 2023
4 checks passed
@ABizzinotto ABizzinotto deleted the ROAD-540-escape-html branch September 6, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description and extra fields don't escape HTML code
4 participants