Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move copy story url to clipboard button to the story dropdown menu #232

Merged
merged 7 commits into from
Oct 10, 2023

Conversation

mcelaney
Copy link
Contributor

@mcelaney mcelaney commented Mar 10, 2022

Closes #218

Description:

Depending on the length of a story description the "copy url to clipboard" icon could appear on the next line like so:

155324141-810f6ea9-eff6-4bea-8e19-ad8160fce859

Moved the button from being a hidden transition without a static location to the dropdown menu:

Screen Shot 2022-03-10 at 2 08 42 PM


I will abide by the code of conduct.

Jira link https://ombulabs.atlassian.net/browse/DT-216

@mcelaney mcelaney requested a review from a team as a code owner March 10, 2022 19:18
@mcelaney mcelaney requested review from lubc and kindoflew and removed request for a team March 10, 2022 19:18
@mcelaney mcelaney added the help wanted Extra attention is needed label Mar 10, 2022
@mcelaney
Copy link
Contributor Author

Question for our JavaScript-savvy friends - looking at issue 218 on Points and I'm proposing moving the copy-to-clipboard link to the story dropdown. This works fine (see screenshot) if everyone is ok with the design change but for some reason I can't figure out the success-alert popup no longer shows up. Looking at action_plan.js it seems like it should... not sure how I broke what I broke?

@FionaDL
Copy link
Member

FionaDL commented Mar 10, 2022

Hey @mcelaney I imagine that the issue is not with the javascript, but with the css. The popup was happening within the container of the story before and the css surrounding it was based on it being in that location. I can see that when I inspect and click on the copy, it is momentarily changing the style in the code, but I think it won't work because the css doesn't make sense inside the dropdown menu. I could be wrong, but I believe that is what is happening.

@mcelaney mcelaney removed the help wanted Extra attention is needed label Mar 12, 2022
@mcelaney
Copy link
Contributor Author

@FionaDL That helped - thanks!

Copy link
Contributor

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mcelaney the change looks good, one thing that looks like it's broken is the position of the Copied to clipboard popup, maybe it can popup on the right side of the row? something like left: 100%

app/views/projects/show.html.erb Outdated Show resolved Hide resolved
@mcelaney
Copy link
Contributor Author

@arielj

hey @mcelaney the change looks good, one thing that looks like it's broken is the position of the Copied to clipboard popup, maybe it can popup on the right side of the row? something like `left: 100%

That'll run it off the screen at most resolutions - how about left: 80% and have it touching the hotdog button that started it?

Screen Shot 2022-03-16 at 4 29 14 PM
`

@arielj
Copy link
Contributor

arielj commented Mar 18, 2022

@arielj

hey @mcelaney the change looks good, one thing that looks like it's broken is the position of the Copied to clipboard popup, maybe it can popup on the right side of the row? something like `left: 100%

That'll run it off the screen at most resolutions - how about left: 80% and have it touching the hotdog button that started it?

Screen Shot 2022-03-16 at 4 29 14 PM `

To prevent the message to overflow on smaller devices maybe a right: 30px is more consistent.

@rishijain
Copy link
Contributor

hey @mcelaney can you please address the comments by Ariel here and let us know if no changes are needed, we will then further take this for QA? Thanks !

@rishijain
Copy link
Contributor

Hey @mcelaney did you get a chance to look at it further?

@FionaDL FionaDL temporarily deployed to points-bug-218-clipboar-njylyg October 9, 2023 20:50 Inactive
@etagwerker etagwerker temporarily deployed to points-bug-218-clipboar-az8mlz October 10, 2023 07:04 Inactive
@etagwerker etagwerker temporarily deployed to points-bug-218-clipboar-zrjrnj October 10, 2023 07:51 Inactive
@rishijain rishijain temporarily deployed to points-bug-218-clipboar-zrjrnj October 10, 2023 08:09 Inactive
Copy link
Contributor

@hmdros hmdros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. ✅

@FionaDL FionaDL temporarily deployed to points-bug-218-clipboar-mkudg0 October 10, 2023 15:44 Inactive
@FionaDL
Copy link
Member

FionaDL commented Oct 10, 2023

@rishijain @hmdros QA looks good, merging! Nice Job!

@FionaDL FionaDL merged commit 5018044 into main Oct 10, 2023
3 checks passed
@FionaDL FionaDL deleted the bug/218-clipboard-button-shifts branch October 10, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy to clipboard button shows up in next line if story title using the complete first line
6 participants