-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move copy story url to clipboard button to the story dropdown menu #232
Conversation
Question for our JavaScript-savvy friends - looking at issue 218 on Points and I'm proposing moving the copy-to-clipboard link to the story dropdown. This works fine (see screenshot) if everyone is ok with the design change but for some reason I can't figure out the success-alert popup no longer shows up. Looking at action_plan.js it seems like it should... not sure how I broke what I broke? |
Hey @mcelaney I imagine that the issue is not with the javascript, but with the css. The popup was happening within the container of the story before and the css surrounding it was based on it being in that location. I can see that when I inspect and click on the copy, it is momentarily changing the style in the code, but I think it won't work because the css doesn't make sense inside the dropdown menu. I could be wrong, but I believe that is what is happening. |
@FionaDL That helped - thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @mcelaney the change looks good, one thing that looks like it's broken is the position of the Copied to clipboard
popup, maybe it can popup on the right side of the row? something like left: 100%
That'll run it off the screen at most resolutions - how about |
To prevent the message to overflow on smaller devices maybe a |
hey @mcelaney can you please address the comments by Ariel here and let us know if no changes are needed, we will then further take this for QA? Thanks ! |
Hey @mcelaney did you get a chance to look at it further? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. ✅
@rishijain @hmdros QA looks good, merging! Nice Job! |
Closes #218
Description:
Depending on the length of a story description the "copy url to clipboard" icon could appear on the next line like so:
Moved the button from being a hidden transition without a static location to the dropdown menu:
I will abide by the code of conduct.
Jira link https://ombulabs.atlassian.net/browse/DT-216