-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a LSTM-CRF model at Conlll2003 Dataset #122
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=========================================
- Coverage 70.31% 70.2% -0.12%
=========================================
Files 82 82
Lines 5407 5407
=========================================
- Hits 3802 3796 -6
- Misses 1605 1611 +6
Continue to review full report at Codecov.
|
Great! |
Update README
OK, I have updated my commit just now, thanks for your careful review. |
i think the data as well as the training code may not necessary in reproduction |
Thanks for your comments @xuyige , the followings are my replies and proposals: Reply
ProposalBased on the design of how tf&pytorch loaded the mnist dataset(by network), I think the fastNLP may consider the data downloading APIs for some widely acknowledged NLP datasets, eg, SQUAD. |
i am so regret to point out that the char-aware-nlm were borrowed from other projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be working, codes seem to be fine
but things still don't add up
I am currently working on this one
Thanks for your review~ |
Yes, we don't have load_data function. You may use an old version. |
Description
Add the LSTM-CRF model for Conll2003 dataset at reproduction dir based on fastNLP lib, inspired by the paper https://arxiv.org/pdf/1508.01991.pdf
Main reason
Provide a new demo for how fastNLP can facilitate the development of the deep learning model. FYI:
https://github.com/hazelnutsgz/fastNLP/tree/hazelnutsgz-crf-lstm/reproduction/LSTM-CRF
Checklist 检查下面各项是否完成
Please feel free to remove inapplicable items for your PR.
Changes
Mention:
@yhcc @xpqiu @FengZiYjun @2017alan