Fix FoldConstants tranformation exiting early to redo shape annotations #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iksnagreb/qonnx into iksnagreb-feature/sort_commutative_inputs
This fixes some weird behavior where folding multiple nodes at once breaks the graph after the next shape inference.
13 tasks
…nference_cost_breakdown inference cost breakdown
…eature/readme_dev_updates Updates to dev docs: pip upgrade, linting
…_commutative_inputs Add cleanup transformation sorting inputs of commutative operations
…b/qonnx into iksnagreb-fix/remove_identity_ops
…dentity_ops Fix RemoveIdentityOps not correctly handling ops following fork-nodes
…eature/remove_id_dropout Remove Dropout with ratio=0 with RemoveIdentityOps
now we have the tests to show that this works fine
…eature/remove_forked_identity Remove identity nodes with output forking
…eature/fp16_fixes Fixes for fp16 tensors and datatypes in ONNX
… into iksnagreb-fix/fold_constants
|
Thank you @iksnagreb - LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some weird behavior where folding multiple nodes at once breaks the graph after the next shape inference. Closes #104