Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch upsample support #951

Closed

Conversation

m-glowacki
Copy link

Adding PyTorch Upsample Layer Support and Fixing Output Shape Batch Dimension

Description:
This PR introduces support for PyTorch Upsample layers and addresses a bug related to output shapes in pytorch convolution and pooling handlers:

Commit 1 (bug fix):

Description: Fixing output shapes by removing the unexpected batch dimension.
Details: Resolved an issue where the batch dimension was present in output shapes for each handler, which was not expected input for parse_data_format.

Commit 2 (adding layer support):

Description: Adding support for PyTorch Upsample layers.
Details: Implemented PyTorch Upsample handler and revised the Resize layer to handle channel_first input (default to Pytorch).

@jmitrevs
Copy link
Contributor

jmitrevs commented Jan 8, 2024

Please fix the pre-commit and then we can try running the pytests.

@jmitrevs
Copy link
Contributor

It still fails the pre-commit.

@m-glowacki
Copy link
Author

Any advice on how to de-bug this? Seems to be failing the black linter hook, however I already ran this locally to make sure if was compliant with the standard and pushed those changes. There are files being pointed to which have not been modified by this PR.

@vloncar
Copy link
Contributor

vloncar commented Jan 23, 2024

pre-commit.ci autofix

@vloncar vloncar added the please test Trigger testing by creating local PR branch label Jan 23, 2024
@m-glowacki
Copy link
Author

I see a couple of the pytests have failed due to time out, can this be reviewed and re-ran if needed?

@vloncar vloncar mentioned this pull request Mar 6, 2024
7 tasks
@vloncar
Copy link
Contributor

vloncar commented Mar 6, 2024

I tried this out, but it has some issues and incorrect changes (Conv2D-related commit in particular). Due to the style changes black made, I ended up making a clean reimplementation of this in a new PR. Closing.

@vloncar vloncar closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants