-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depthwise convolution for oneAPI #1131
Depthwise convolution for oneAPI #1131
Conversation
Is it worth adding 1D versions, too? |
Why so many commits? Is it worth rebasing on a new branch from main? |
hls4ml/templates/oneapi/firmware/nnet_utils/nnet_depthconv2d_resource.h
Outdated
Show resolved
Hide resolved
hls4ml/templates/oneapi/firmware/nnet_utils/nnet_depthconv2d_resource.h
Outdated
Show resolved
Hide resolved
hls4ml/templates/oneapi/firmware/nnet_utils/nnet_depthconv2d_resource.h
Outdated
Show resolved
Hide resolved
Will this really add 129 new commits, or is this just some confusion? Might be good to squash the commits to prevent that. |
It should be squashed. |
The squashing would be when we merge the PR, by selecting squash and merge, right? There's no need to manually squash the commits. |
Ah, yes. I was looking for a squash button yesterday, didn't realize it was in the drop down next to the green button. I'll merge now. |
Description
Type of change
Adding Depthwise convolution in a parallel implementation. Supports depth multiplier. When a separable convolution layer is used, it is split to depthwise and pointwise layers.
Note: Please delete options that are not relevant.
Tests
Test Configuration:
Checklist
pre-commit
on the files I edited or added.