clang-format change: one arg per line for long function call/def

[calad0i]

Description

Change clang-format config so that long function call/def will have each argument taking a new line, with brackets in their own lines.

The current formatter breaks only when a line is filled, causing multiple parameters sharing the same line, which creates walls of code that are not easy to read. This should mitigate the issue.

Drawback: A few super long template from ac_math.h looks bad now, but as they are not that much better before I guess it's a reasonable tradeoff...

Example:

Current:

template <class data_T, class res_T, typename CONFIG_T>
void dense(data_T data[CONFIG_T::n_in], res_T res[CONFIG_T::n_out],
           typename CONFIG_T::weight_t weights[CONFIG_T::n_in * CONFIG_T::n_out],
           typename CONFIG_T::bias_t biases[CONFIG_T::n_out]) {
    #pragma HLS INLINE
    CONFIG_T::template kernel<data_T, res_T, CONFIG_T>::dense(data, res, weights, biases);
}

Modified:

template <class data_T, class res_T, typename CONFIG_T>
void dense(
    data_T data[CONFIG_T::n_in],
    res_T res[CONFIG_T::n_out],
    typename CONFIG_T::weight_t weights[CONFIG_T::n_in * CONFIG_T::n_out],
    typename CONFIG_T::bias_t biases[CONFIG_T::n_out]
) {
    #pragma HLS INLINE
    CONFIG_T::template kernel<data_T, res_T, CONFIG_T>::dense(data, res, weights, biases);
}

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

• Cosmatic

Tests

📝 Please describe the tests that you ran to verify your changes.

• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

Test Configuration:

Checklist

• I have read the guidelines for contributing.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• I have installed and run pre-commit on the files I edited or added.
• I have added tests that prove my fix is effective or that my feature works.

[vloncar]

I agree that the function declarations look nicer this way, that used to be the preferred-but-not-enforced style before we started using clang-format. However, the template declaration now looks really ugly.

Also, after hours of fiddling, I never managed to get labels to be indented and align to the code (in our case the loop), instead they are always aligned at the level of the surrounding brace. This is the biggest eyesore in the current codebase. Any suggestions as to how to fix that? Seems to be doable with astyle, but clang-format is more powerful and generally recommended, so I'd rather not switch the formatter