-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(product_enablement) - Add support for Fastly Bot Management. #880
feat(product_enablement) - Add support for Fastly Bot Management. #880
Conversation
Co-authored-by: Kevin P. Fleming <[email protected]>
@kpfleming Now that this PR (fastly/go-fastly#539) has been merged, are there are additional steps required before this PR may be merged? |
I believe the answer is:
|
fastly/block_fastly_service_product_enablement.go
@kpfleming I reverted my changes to the vendor file [vendor/github.com/fastly/go-fastly/v9/fastly/product_enablement.go]. However, now the tests are failing. How may I pass the tests without modifying the product_enablement.go file directly? |
Your last commit 22a07f2 seems to revert the changes made by |
@Integralist Correct. Should I not do that? Or should I run |
That's correct, run e.g. you'll see |
@Integralist @kpfleming Done. Let me know if I need to make any further modifications. Thanks for the guidance! |
@kpfleming you'll probably want to run the complete e2e tests as I don't think @BrooksCunningham will have the relevant access to do that. |
Yep. We'll also need to get that product enabled on the SID we use for those tests. |
Acceptance tests for this feature pass as planned. |
This PR adds the ability to enable Fastly Bot Management via the product_enablement field in a fastly_service_vcl resource. Below is an example with
bot_management
enabled.I have successfully tested locally and updated the test file
fastly/block_fastly_service_product_enablement_test.go
to have the fieldbot_management = false
.Please let me know if there are any other tests that I may run or updates that I may make to help get this PR merged. Thanks!