Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image_optimizer_default_settings): add Image Optimizer default settings API #832

Merged

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    cb77273 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2eaeb81 View commit details
    Browse the repository at this point in the history
  3. Generate docs.

    daboross committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a0b9545 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    25ccca5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    913522b View commit details
    Browse the repository at this point in the history
  6. PR cleanup suggestion.

    daboross committed May 9, 2024
    Configuration menu
    Copy the full SHA
    db46c0f View commit details
    Browse the repository at this point in the history
  7. Include default values.

    I was initially trying to get Terraform to ignore settings that wern't
    set in the configuration, leaving them at their previously configured
    value. This seems to be counter to Terraform's design, though, so I've
    relented & included the current default values for each setting here.
    
    It seems like maybe we could have done that for the string values, and
    non-0 integers, but it seems like a nonstarter for booleans
    (hashicorp/terraform-plugin-sdk#817), and
    I didn't want to go against Terraform's design too much.
    daboross committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ec9c0c9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cb73136 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    17785ea View commit details
    Browse the repository at this point in the history
  10. One more vendor update.

    daboross committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a21b898 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    817f5f9 View commit details
    Browse the repository at this point in the history
  12. Update vendored code again.

    daboross committed May 9, 2024
    Configuration menu
    Copy the full SHA
    eddada9 View commit details
    Browse the repository at this point in the history
  13. Update field documentation.

    Part of this is updating field with descriptions from the final
    api-documentation PR. The other part is just my messing with stuff to
    try to make it look better.
    daboross committed May 9, 2024
    Configuration menu
    Copy the full SHA
    aef2f4c View commit details
    Browse the repository at this point in the history
  14. Update generated docs

    (also, move image_optimizer_default_settings guide from docs to templates)
    daboross committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2a33604 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    60ba6ef View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b90906b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    dcfb360 View commit details
    Browse the repository at this point in the history
  2. Add debug message for ignoring image-optimizer-disabled error on dele…

    …tion.
    
    This is working well! Just wanted to add this to double-confirm it's
    doing what I expect.
    daboross committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e4cebed View commit details
    Browse the repository at this point in the history
  3. Remove toolchain directive.

    daboross committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2bcda5f View commit details
    Browse the repository at this point in the history
  4. Undo go version bump.

    Not sure why updating had caused this, but this should still work.
    daboross committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7ffa4f6 View commit details
    Browse the repository at this point in the history