-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(image_optimizer_default_settings): add Image Optimizer default settings API #832
Merged
Integralist
merged 20 commits into
fastly:main
from
daboross:dross/image-optimizer-default-settings-api
May 16, 2024
Merged
feat(image_optimizer_default_settings): add Image Optimizer default settings API #832
Integralist
merged 20 commits into
fastly:main
from
daboross:dross/image-optimizer-default-settings-api
May 16, 2024
Commits on May 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb77273 - Browse repository at this point
Copy the full SHA cb77273View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2eaeb81 - Browse repository at this point
Copy the full SHA 2eaeb81View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0b9545 - Browse repository at this point
Copy the full SHA a0b9545View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25ccca5 - Browse repository at this point
Copy the full SHA 25ccca5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 913522b - Browse repository at this point
Copy the full SHA 913522bView commit details -
Configuration menu - View commit details
-
Copy full SHA for db46c0f - Browse repository at this point
Copy the full SHA db46c0fView commit details -
I was initially trying to get Terraform to ignore settings that wern't set in the configuration, leaving them at their previously configured value. This seems to be counter to Terraform's design, though, so I've relented & included the current default values for each setting here. It seems like maybe we could have done that for the string values, and non-0 integers, but it seems like a nonstarter for booleans (hashicorp/terraform-plugin-sdk#817), and I didn't want to go against Terraform's design too much.
Configuration menu - View commit details
-
Copy full SHA for ec9c0c9 - Browse repository at this point
Copy the full SHA ec9c0c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb73136 - Browse repository at this point
Copy the full SHA cb73136View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17785ea - Browse repository at this point
Copy the full SHA 17785eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a21b898 - Browse repository at this point
Copy the full SHA a21b898View commit details -
Configuration menu - View commit details
-
Copy full SHA for 817f5f9 - Browse repository at this point
Copy the full SHA 817f5f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eddada9 - Browse repository at this point
Copy the full SHA eddada9View commit details -
Part of this is updating field with descriptions from the final api-documentation PR. The other part is just my messing with stuff to try to make it look better.
Configuration menu - View commit details
-
Copy full SHA for aef2f4c - Browse repository at this point
Copy the full SHA aef2f4cView commit details -
(also, move image_optimizer_default_settings guide from docs to templates)
Configuration menu - View commit details
-
Copy full SHA for 2a33604 - Browse repository at this point
Copy the full SHA 2a33604View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60ba6ef - Browse repository at this point
Copy the full SHA 60ba6efView commit details -
Configuration menu - View commit details
-
Copy full SHA for b90906b - Browse repository at this point
Copy the full SHA b90906bView commit details
Commits on May 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dcfb360 - Browse repository at this point
Copy the full SHA dcfb360View commit details -
Add debug message for ignoring image-optimizer-disabled error on dele…
…tion. This is working well! Just wanted to add this to double-confirm it's doing what I expect.
Configuration menu - View commit details
-
Copy full SHA for e4cebed - Browse repository at this point
Copy the full SHA e4cebedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bcda5f - Browse repository at this point
Copy the full SHA 2bcda5fView commit details -
Not sure why updating had caused this, but this should still work.
Configuration menu - View commit details
-
Copy full SHA for 7ffa4f6 - Browse repository at this point
Copy the full SHA 7ffa4f6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.