Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tls_mutual_authentication): update activation after mtls creation #829

Merged
merged 13 commits into from
Apr 15, 2024

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Apr 9, 2024

Fix fastly_tls_mutual_authentication.

There are two steps to setting up mTLS:

  1. POST /tls/mutual_authentications
  2. PATCH /tls/activations/tls_activation_id

The original implementation was missing the second part.

@Integralist Integralist added the bug label Apr 9, 2024
@Integralist Integralist changed the title Integralist/fix mtls fix(tls_mutual_authentication): update activation after mtls creation Apr 9, 2024
@bryangm
Copy link

bryangm commented Apr 10, 2024

From a TLS perspective, the examples and basic usage all made sense. I'm unfamiliar with TF but got the gist of including the PATCH activation call within the mutual_authentication resource

@Integralist Integralist removed the request for review from gschorkopf April 10, 2024 09:36
@Integralist Integralist force-pushed the integralist/fix-mtls branch 5 times, most recently from a2706cc to b804f54 Compare April 10, 2024 14:56
@Integralist Integralist merged commit 1ac8dc0 into main Apr 15, 2024
11 checks passed
@Integralist Integralist deleted the integralist/fix-mtls branch April 15, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants