Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow certainly as a certificate authority #648

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Allow certainly as a certificate authority #648

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eafde37
Allow `certainly` as a certificate authority
sjparkinson Feb 28, 2023
0bb4b96
Update docs for `fastly_tls_subscription` resource
sjparkinson Feb 28, 2023
da8fe66
Update fastly/resource_fastly_tls_subscription.go
Integralist Feb 28, 2023
3193d07
Update docs/resources/tls_subscription.md
Integralist Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/tls_subscription.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ $ terraform import fastly_tls_subscription.demo xxxxxxxxxxx

### Required

- `certificate_authority` (String) The entity that issues and certifies the TLS certificates for your subscription. Valid values are `lets-encrypt` or `globalsign`.
- `certificate_authority` (String) The entity that issues and certifies the TLS certificates for your subscription. Valid values are `lets-encrypt`, `globalsign` or `certainly`.
Integralist marked this conversation as resolved.
Show resolved Hide resolved
- `domains` (Set of String) List of domains on which to enable TLS.

### Optional
Expand Down
4 changes: 2 additions & 2 deletions fastly/resource_fastly_tls_subscription.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ func resourceFastlyTLSSubscription() *schema.Resource {
Schema: map[string]*schema.Schema{
"certificate_authority": {
Type: schema.TypeString,
Description: "The entity that issues and certifies the TLS certificates for your subscription. Valid values are `lets-encrypt` or `globalsign`.",
Description: "The entity that issues and certifies the TLS certificates for your subscription. Valid values are `lets-encrypt`, `globalsign` or `certainly`.",
Integralist marked this conversation as resolved.
Show resolved Hide resolved
Required: true,
ForceNew: true,
ValidateFunc: validation.StringInSlice([]string{"lets-encrypt", "globalsign"}, false),
ValidateFunc: validation.StringInSlice([]string{"lets-encrypt", "globalsign", "certainly"}, false),
},
"certificate_id": {
Type: schema.TypeString,
Expand Down