Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certainly as a certificate authority #648

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Allow certainly as a certificate authority #648

merged 4 commits into from
Feb 28, 2023

Conversation

sjparkinson
Copy link
Contributor

As the product has been announced in https://www.fastly.com/blog/announcing-certainly-fastlys-own-tls-certification-authority, it'd be great to support it in this Terraform provider.

@Integralist
Copy link
Collaborator

@sjparkinson Thanks! I didn't notice at first that this was a PR and not just an issue 🙂

@Integralist
Copy link
Collaborator

@sjparkinson could you run make generate-docs and commit the changes. That will resolve the failing 'docs' CI step.

Thanks!

@sjparkinson
Copy link
Contributor Author

I didn't notice at first that this was a PR and not just an issue 🙂

Small enough change I figure why not 😅. Was a good excuse to try a Go project in a Codespace as I don't have that toolchain setup locally.

@Integralist
Copy link
Collaborator

@sjparkinson I'm going to merge this PR now and then tomorrow I'll do some manual testing to validate all is well before cutting a new release.

@Integralist Integralist merged commit 8aca814 into fastly:main Feb 28, 2023
@sjparkinson sjparkinson deleted the certainly branch February 28, 2023 20:21
@Integralist Integralist added the enhancement New feature or request label Mar 2, 2023
@RoseSecurity
Copy link
Contributor

Is this still considered beta?

@Integralist
Copy link
Collaborator

Thanks @RoseSecurity you're quite right as this went GA in August:
https://www.fastly.com/blog/announcing-certainly-fastlys-own-tls-certification-authority

We'll get the docs updated.

Thanks!

@RoseSecurity
Copy link
Contributor

RoseSecurity commented Apr 5, 2024

Thanks @RoseSecurity you're quite right as this went GA in August: https://www.fastly.com/blog/announcing-certainly-fastlys-own-tls-certification-authority

We'll get the docs updated.

Thanks!

Here is a PR to assist: #826 @Integralist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants