Skip to content

Commit 817d43a

Browse files
author
Jake Champion
committed
use slice.data directly as it is null terminated
1 parent 50b91c4 commit 817d43a

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

c-dependencies/js-compute-runtime/builtins/backend.cpp

+3-4
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,6 @@ JSObject *Backend::create(JSContext *cx, JS::HandleObject request) {
510510
return nullptr;
511511
}
512512
const jsurl::SpecSlice slice = jsurl::host(url);
513-
std::string aaa((char *)slice.data, slice.len);
514513
auto nameStr = JS_NewStringCopyN(cx, (char *)slice.data, slice.len);
515514
if (!nameStr) {
516515
return nullptr;
@@ -519,11 +518,11 @@ JSObject *Backend::create(JSContext *cx, JS::HandleObject request) {
519518
// Check if we already constructed an implicit dynamic backend for this host.
520519
bool found;
521520
JS::RootedValue alreadyBuiltBackend(cx);
522-
if (!JS_HasProperty(cx, Backend::backends, aaa.c_str(), &found)) {
521+
if (!JS_HasProperty(cx, Backend::backends, reinterpret_cast<const char *>(slice.data), &found)) {
523522
return nullptr;
524523
}
525524
if (found) {
526-
if (!JS_GetProperty(cx, Backend::backends, aaa.c_str(), &alreadyBuiltBackend)) {
525+
if (!JS_GetProperty(cx, Backend::backends, reinterpret_cast<const char *>(slice.data), &alreadyBuiltBackend)) {
527526
return nullptr;
528527
}
529528
JS::RootedObject backend(cx, &alreadyBuiltBackend.toObject());
@@ -560,7 +559,7 @@ JSObject *Backend::create(JSContext *cx, JS::HandleObject request) {
560559
if (result.isErr()) {
561560
return nullptr;
562561
} else {
563-
if (!JS_SetProperty(cx, Backend::backends, aaa.c_str(), backendVal)) {
562+
if (!JS_SetProperty(cx, Backend::backends, reinterpret_cast<const char *>(slice.data), backendVal)) {
564563
return nullptr;
565564
}
566565
return backend;

0 commit comments

Comments
 (0)