make fields in DynamicBackendConfig be const

Author: Jake Champion

c-dependencies/js-compute-runtime/builtins/backend.cpp

@@ -335,39 +335,39 @@ JS::Result<mozilla::Ok> Backend::register_dynamic_backend(JSContext *cx, JS::Han
   auto target_cstr = targetChars.get();
   if (hostOverride.has_value()) {
     backend_config_mask |= BACKEND_CONFIG_HOST_OVERRIDE;
-    definition.host_override = (char *)hostOverride.value().c_str();
+    definition.host_override = hostOverride.value().c_str();
     definition.host_override_len = hostOverride.value().length();
   } else {
     definition.host_override = nullptr;
     definition.host_override_len = 0;
   }
   if (certificateHostname.has_value()) {
     backend_config_mask |= BACKEND_CONFIG_CERT_HOSTNAME;
-    definition.cert_hostname = (char *)certificateHostname.value().c_str();
+    definition.cert_hostname = certificateHostname.value().c_str();
     definition.cert_hostname_len = certificateHostname.value().length();
   } else {
     definition.cert_hostname = nullptr;
     definition.cert_hostname_len = 0;
   }
   if (caCertificate.has_value()) {
     backend_config_mask |= BACKEND_CONFIG_CA_CERT;
-    definition.ca_cert = (char *)caCertificate.value().c_str();
+    definition.ca_cert = caCertificate.value().c_str();
     definition.ca_cert_len = caCertificate.value().length();
   } else {
     definition.ca_cert = nullptr;
     definition.ca_cert_len = 0;
   }
   if (ciphers.has_value()) {
     backend_config_mask |= BACKEND_CONFIG_CIPHERS;
-    definition.ciphers = (char *)ciphers.value().c_str();
+    definition.ciphers = ciphers.value().c_str();
     definition.ciphers_len = ciphers.value().length();
   } else {
     definition.ciphers = nullptr;
     definition.ciphers_len = 0;
   }
   if (sniHostname.has_value()) {
     backend_config_mask |= BACKEND_CONFIG_SNI_HOSTNAME;
-    definition.sni_hostname = (char *)sniHostname.value().c_str();
+    definition.sni_hostname = sniHostname.value().c_str();
     definition.sni_hostname_len = sniHostname.value().length();
   } else {
     definition.sni_hostname = nullptr;

c-dependencies/js-compute-runtime/xqd.h

@@ -74,20 +74,20 @@ typedef enum TLS {
 } TLS;
 
 typedef struct DynamicBackendConfig {
-  char *host_override;
+  const char *host_override;
   uint32_t host_override_len;
   uint32_t connect_timeout_ms;
   uint32_t first_byte_timeout_ms;
   uint32_t between_bytes_timeout_ms;
   uint32_t ssl_min_version;
   uint32_t ssl_max_version;
-  char *cert_hostname;
+  const char *cert_hostname;
   uint32_t cert_hostname_len;
-  char *ca_cert;
+  const char *ca_cert;
   uint32_t ca_cert_len;
-  char *ciphers;
+  const char *ciphers;
   uint32_t ciphers_len;
-  char *sni_hostname;
+  const char *sni_hostname;
   uint32_t sni_hostname_len;
 } DynamicBackendConfig;